Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add config to generate file extensions for module resolution no… #644

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add config to generate file extensions for module resolution no… #644

wants to merge 3 commits into from

Conversation

omridevk
Copy link

…de16+

@stackblitz StackBlitz
Copy link

stackblitz bot commented May 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e6be2dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 9:14am

@omridevk omridevk mentioned this pull request May 30, 2024
Open
@omridevk
Copy link
Author

fixes:
#478 and #595

@mrlubos
Copy link
Member

mrlubos commented May 30, 2024

Hey, can you resolve the conflicts please? This doesn't seem to work based on tsconfig, am I right? If so, why include changes to tsconfig in the diff?

mrlubos
mrlubos reviewed May 30, 2024
View reviewed changes
packages/openapi-ts/test/e2e/scripts/compileWithTypescript.ts
@@ -1,6 +1,6 @@
import path from 'node:path'

import { EOL } from 'os'
import {EOL} from 'os'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change made by a formatter?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@omridevk
Copy link
Author

Hey, can you resolve the conflicts please? This doesn't seem to work based on tsconfig, am I right? If so, why include changes to tsconfig in the diff?

yes, I do want to create a failing test based on the new config overrides.

Will resolve conflicts.

@omridevk
Copy link
Author

omridevk commented Jun 9, 2024

@mrlubos
Resolved the conflicts.

mrlubos
mrlubos requested changes Jun 9, 2024
View reviewed changes
pnpm-lock.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this diff?

@mrlubos
Copy link
Member

mrlubos commented Jun 9, 2024

This doesn't seem to work based on tsconfig, am I right? If so, why include changes to tsconfig in the diff?

@martinssonj
Copy link

Any updates on this issue? Recently, I started a new project with ESM and ran into this problem.

@omridevk
Copy link
Author

@martinssonj
We have been using this to resolve the issue in our build, couldn't find a time to fix this PR yet :(
https://github.com/GervinFung/ts-add-js-extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrlubos mrlubos mrlubos requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omridevk @mrlubos @martinssonj